]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
Fix various Coverity-detected errors in nvmecontrol
authordab <dab@FreeBSD.org>
Thu, 2 Apr 2020 13:52:54 +0000 (13:52 +0000)
committerdab <dab@FreeBSD.org>
Thu, 2 Apr 2020 13:52:54 +0000 (13:52 +0000)
commit89bf75dc596cd8f9dae50f4741c1d834e4a9d003
treeda39298c679f5f7f9adf8b29452bc9d54c4ce6dd
parentee39dcd0244e9e1e48660ad9e52c9e531a8bd10d
Fix various Coverity-detected errors in nvmecontrol

This fixes several Coverity-detected errors in nvmecontrol. While in
here, a couple additional errors with shift/mask confusion that were
not diagnosed by Coverity are also fixed.

CIDs addressed: 104029910403001403972140397314039851403988,
1403990140437414044271404469140451014045341418118

CID 1403657 (resource leak of shared library handle) was marked
"intentional" in the Coverity scan database.

Reviewed by: vangyzen, robert.herndon_dell.com
Reviewed by: daniel.william.ryan_gmail.com (earlier version)
Reviewed by: rramsden_isilon.com (earlier version), imp
MFC after: 5 days
Sponsored by: Dell EMC Isilon
Differential Revision: https://reviews.freebsd.org/D24203
sbin/nvmecontrol/firmware.c
sbin/nvmecontrol/identify.c
sbin/nvmecontrol/logpage.c
sbin/nvmecontrol/modules/wdc/wdc.c
sbin/nvmecontrol/nsid.c
sbin/nvmecontrol/passthru.c
sbin/nvmecontrol/power.c
sbin/nvmecontrol/reset.c