]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
libradius: Fix attribute length validation in rad_get_attr(3)
authorMark Johnston <markj@FreeBSD.org>
Fri, 28 May 2021 14:41:43 +0000 (10:41 -0400)
committerMark Johnston <markj@FreeBSD.org>
Tue, 1 Jun 2021 20:30:41 +0000 (16:30 -0400)
commita946f99873fc09ad30ae0cc9c9ad01e39466fa5f
tree8bbfa68085c35ba4b304a8a02c0c035703521aeb
parentf5ddeabc08e7f8a1c371dc1803c02d4a415817f1
libradius: Fix attribute length validation in rad_get_attr(3)

The length of the attribute header needs to be excluded when comparing
the attribute length against the length of the packet.  Otherwise,
validation may incorrectly fail when fetching the final attribute in a
message.

Approved by: so
Security: FreeBSD-EN-21:17.libradius
Fixes: 8d5c78130 ("libradius: Fix input validation bugs")
Reported by: Peter Eriksson
Tested by: Peter Eriksson
Sponsored by: The FreeBSD Foundation

(cherry picked from commit 6bb5699d2b59491097bc21ffa3c097cdd4853f89)
(cherry picked from commit f9972532343bb1eb101bf7afef2966972eea3b5e)
lib/libradius/radlib.c