]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
Spam CXXFLAGS with `-I${DESTDIR}/usr/include/private`, instead of GTEST_CXXFLAGS
authorngie <ngie@FreeBSD.org>
Thu, 28 Mar 2019 17:22:31 +0000 (17:22 +0000)
committerngie <ngie@FreeBSD.org>
Thu, 28 Mar 2019 17:22:31 +0000 (17:22 +0000)
commitbc27d36f90f945e494725557b9caa8c2759543d9
tree45506b339b70f8b86ab9537b943ed76ac4899ab5
parentbd3bd9d6bef758bc2371fba7377323d0d4c326c4
Spam CXXFLAGS with `-I${DESTDIR}/usr/include/private`, instead of GTEST_CXXFLAGS

This makes it easier for googletest users to leverage googletest, instead of
forcing them to plug GTEST_CXXFLAGS into CXXFLAGS manually (resulting in
unnecessary duplication).

I will be following this up with a more proper fix in src.libnames.mk, as
src.libnames.mk should be automatically adding this directory to
CFLAGS/CXXFLAGS when private libraries are referenced. Not doing so can result
in mismatches between base-provided private library's and ports-provided
library's headers.

While here, tweak the comment to clarify what the intent is behind spamming
CXXFLAGS.

MFC after: 5 weeks
MFC with: r345203
Reported by: asomers
Reviewed by: asomers
Approved by: emaste (mentor)
Differential Revision: https://reviews.freebsd.org/D19731
share/mk/googletest.test.inc.mk