]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
fusefs: fix mmap'd writes in direct_io mode
authorasomers <asomers@FreeBSD.org>
Thu, 24 Sep 2020 16:27:53 +0000 (16:27 +0000)
committerasomers <asomers@FreeBSD.org>
Thu, 24 Sep 2020 16:27:53 +0000 (16:27 +0000)
commitd0def21d9acf34f80153650c9e2610cb0b8b7fa8
treec37c6bff8628c8df368c90cb905af577f01837af
parent2c79e4bbcd5339eb922949954423f6820834cdf9
fusefs: fix mmap'd writes in direct_io mode

If a FUSE server returns FOPEN_DIRECT_IO in response to FUSE_OPEN, that
instructs the kernel to bypass the page cache for that file. This feature
is also known by libfuse's name: "direct_io".

However, when accessing a file via mmap, there is no possible way to bypass
the cache completely. This change fixes a deadlock that would happen when
an mmap'd write tried to invalidate a portion of the cache, wrongly assuming
that a write couldn't possibly come from cache if direct_io were set.

Arguably, we could instead disable mmap for files with FOPEN_DIRECT_IO set.
But allowing it is less likely to cause user complaints, and is more in
keeping with the spirit of open(2), where O_DIRECT instructs the kernel to
"reduce", not "eliminate" cache effects.

PR: 247276
Reported by: trapexit@spawn.link
Reviewed by: cem
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D26485
sys/fs/fuse/fuse_io.c
tests/sys/fs/fusefs/write.cc