]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
Merge commit e09107ab8 from llvm git (by Raul Tambre):
authordim <dim@FreeBSD.org>
Thu, 17 Sep 2020 19:43:25 +0000 (19:43 +0000)
committerdim <dim@FreeBSD.org>
Thu, 17 Sep 2020 19:43:25 +0000 (19:43 +0000)
commitde0707eb19c5a7655af45b32c0e9a02b3b1beb6f
tree0479d7ba66f5c03f6ee8ec45948bd8f694a69c11
parent099d99950ed87e3a0cbdbba6066b31f26d41c899
Merge commit e09107ab8 from llvm git (by Raul Tambre):

  [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

  Instead of relying on whether a certain identifier is a builtin,
  introduce BuiltinAttr to specify a declaration as having builtin
  semantics.

  This fixes incompatible redeclarations of builtins, as reverting the
  identifier as being builtin due to one incompatible redeclaration
  would have broken rest of the builtin calls.
  Mostly-compatible redeclarations of builtins also no longer have
  builtin semantics. They don't call the builtin nor inherit their
  attributes.
  A long-standing FIXME regarding builtins inside a namespace enclosed
  in extern "C" not being recognized is also addressed.

  Due to the more correct handling attributes for builtin functions are
  added in more places, resulting in more useful warnings.
  Tests are updated to reflect that.

  Intrinsics without an inline definition in intrin.h had `inline` and
  `static` removed as they had no effect and caused them to no longer
  be recognized as builtins otherwise.

  A pthread_create() related test is XFAIL-ed, as it relied on it being
  recognized as a builtin based on its name.
  The builtin declaration syntax is too restrictive and doesn't allow
  custom structs, function pointers, etc.
  It seems to be the only case and fixing this would require reworking
  the current builtin syntax, so this seems acceptable.

  Fixes PR45410.

  Reviewed By: rsmith, yutsumi

  Differential Revision: https://reviews.llvm.org/D77491

This should fix 'Assertion failed: (i < getNumParams() && "Illegal
param #"), function getParamDecl, file
/usr/src/contrib/llvm-project/clang/include/clang/AST/Decl.h, line 2430'
when building the graphics/pgplot port.

Note that there may also have been other ports which triggered this
assertion, if they redeclare standard functions with incompatible
arguments.

Reported by: zeising
MFC after: 6 weeks
X-MFC-With: r364284
contrib/llvm-project/clang/include/clang/Basic/Attr.td
contrib/llvm-project/clang/include/clang/Basic/Builtins.def
contrib/llvm-project/clang/include/clang/Basic/IdentifierTable.h
contrib/llvm-project/clang/include/clang/Sema/Sema.h
contrib/llvm-project/clang/lib/AST/Decl.cpp
contrib/llvm-project/clang/lib/Headers/intrin.h
contrib/llvm-project/clang/lib/Sema/SemaDecl.cpp
contrib/llvm-project/clang/lib/Sema/SemaExpr.cpp
contrib/llvm-project/clang/lib/Sema/SemaLookup.cpp
contrib/llvm-project/clang/lib/Serialization/ASTReader.cpp
contrib/llvm-project/clang/lib/Serialization/ASTWriter.cpp