]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
freebsd-update: unconditionally regenerate passwd/login.conf files
authorKyle Evans <kevans@FreeBSD.org>
Thu, 17 Dec 2020 03:42:54 +0000 (03:42 +0000)
committerKyle Evans <kevans@FreeBSD.org>
Thu, 17 Dec 2020 03:42:54 +0000 (03:42 +0000)
commitebebc41e4cfe44b8e8fd881badf2fa2c4be65aa4
tree0101f48a4f9ad703afb78624a482490b0adbdcc1
parent228e2087a32847fa51168f3f0c58f931cb2cb0f8
freebsd-update: unconditionally regenerate passwd/login.conf files

The existing logic is nice in theory, but in practice freebsd-update will
not preserve the timestamps on these files. When doing a major upgrade, e.g.
from 12.1-RELEASE -> 12.2-RELEASE, pwd.mkdb et al. appear in the INDEX and
we clobber the timestamp several times in the process of packaging up the
existing system into /var/db/freebsd-update/files and extracting for
comparisons. This leads to these files not getting regenerated when they're
most likely to be needed.

Measures could be taken to preserve timestamps, but it's unclear whether
the complexity and overhead of doing so is really outweighed by the marginal
benefit.

I observed this issue when pkg subsequently failed to install a package that
wanted to add a user, claiming that the user was removed in the process.
bapt@ pointed to this pre-existing bug with freebsd-update as the cause.

PR: 234014, 232921
Reviewed by: bapt, emaste
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D27635
usr.sbin/freebsd-update/freebsd-update.sh