]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
loader: fix elf lookup_symbol type filtering
authorKyle Evans <kevans@FreeBSD.org>
Fri, 14 Oct 2022 03:06:13 +0000 (22:06 -0500)
committerKyle Evans <kevans@FreeBSD.org>
Fri, 14 Oct 2022 03:07:52 +0000 (22:07 -0500)
commit0701dbda94f21de8ddab3113f79262a26cc7b96c
tree132ed3258fcfdbd560256a4ee52302689cb421ae
parented7910fbac07ee39d10528994e49ada2d0f2d754
loader: fix elf lookup_symbol type filtering

The existing logic doesn't seem to make much sense, as we won't filter
on the type if st_shndx != SHN_UNDEF.  In practice, this breaks booting
12.3 kernels on newer loaders, as they do have a `kernphys` symbol of
the wrong type (NOTYPE, rather than OBJECT) -- we end up deriving the
wrong value for copy_staging.

It's unclear if this version makes any more sense, but it seems to match
what rtld's matched_symbol() does.  Loader doesn't need to care about
STT_FUNC w/ UND shndx, because we won't encounter those; in kmods,
undefined (kernel) functions are NOTYPE.

Reported by: Christian McDonald <cmcdonald netgate com>
Reviewed by: imp, kib, tsoome
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D36975
stand/common/load_elf.c