]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
net80211: correct length check in ieee80211_ies_expand()
authorBjoern A. Zeeb <bz@FreeBSD.org>
Wed, 6 Oct 2021 18:09:39 +0000 (18:09 +0000)
committerBjoern A. Zeeb <bz@FreeBSD.org>
Fri, 8 Oct 2021 10:26:22 +0000 (10:26 +0000)
commit09dd08f167812a5fdb516fc98f14dbb43221432f
tree2afe13095455df47f98d6fc326c533b9b5396ac0
parent526370fb85db4b659cff4625eb2f379acaa4a1a8
net80211: correct length check in ieee80211_ies_expand()

In ieee80211_ies_expand() we are looping over Elements
(also known as Information Elements or IEs).
The comment suggests that we assume well-formedness of
the IEs themselves.
Checking the buffer length being least 2 (1 byte Element ID and
1 byte Length fields) rather than just 1 before accessing ie[1]
is still good practise and can prevent and out-of-bounds read in
case the input is not behaving according to the comment.

Reported by: (coypu sdf.org)
admbugs: 857
MFC after: 3 days
Reviewed by: adrian, markj
Differential Revision: https://reviews.freebsd.org/D32340
sys/net80211/ieee80211_node.c