]> CyberLeo.Net >> Repos - FreeBSD/FreeBSD.git/commit
divert: Fix mbuf ownership confusion in div_output()
authorMark Johnston <markj@FreeBSD.org>
Fri, 7 May 2021 18:27:58 +0000 (14:27 -0400)
committerMark Johnston <markj@FreeBSD.org>
Mon, 10 May 2021 13:36:08 +0000 (09:36 -0400)
commiteafeee082c50850c2577f4fce0eaa7acb034f565
tree995f73f325b4dc0321c25ef6bb75c7aab61e40fb
parent44d26e9e781fdf47fe0e1e6c987d519a751b14fa
divert: Fix mbuf ownership confusion in div_output()

div_output_outbound() and div_output_inbound() relied on the caller to
free the mbuf if an error occurred.  However, this is contrary to the
semantics of their callees, ip_output(), ip6_output() and
netisr_queue_src(), which always consume the mbuf.  So, if one of these
functions returned an error, that would get propagated up to
div_output(), resulting in a double free.

Fix the problem by making div_output_outbound() and div_output_inbound()
responsible for freeing the mbuf in all cases.

Reported by: Michael Schmiedgen <schmiedgen@gmx.net>
Tested by: Michael Schmiedgen
Reviewed by: donner
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D30129

(cherry picked from commit a1fadf7de25b973a308b86d04c4ada4fa8be193f)
sys/netinet/ip_divert.c